[feat] Forgejo issues and comment / reactions #959

mfocko · 2025-12-11T09:39:10Z

TODO:

Review to check the current state of the PR.
Write new tests or update the old ones to cover new functionality.
Update doc-strings where appropriate.
Update or write new documentation in packit/packit.dev.
‹fill in›

Fixes #880
Fixes #883

Related to #866

Merge before/after

RELEASE NOTES BEGIN

Ogr now supports Forgejo issues, comments and comment reactions.

RELEASE NOTES END

gemini-code-assist · 2025-12-11T09:39:32Z

Summary of Changes

Hello @mfocko, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces robust support for Forgejo's issue and comment functionalities within the ogr library. It provides a complete set of tools for interacting with Forgejo issues, including their creation, retrieval, modification, and lifecycle management, as well as handling comments and reactions for both issues and pull requests. These enhancements aim to integrate Forgejo more deeply into the ogr ecosystem, offering a consistent interface for managing project discussions and tasks.

Highlights

Forgejo Comments and Reactions: Introduced new classes (ForgejoReaction, ForgejoComment, ForgejoIssueComment, ForgejoPRComment) to provide comprehensive support for managing comments and reactions on Forgejo issues and pull requests.
Enhanced Forgejo Issue Management: Significantly expanded the ForgejoIssue class with capabilities to create, retrieve, list, close, and modify issues, including managing assignees and labels.
Pull Request Comment Support: Implemented methods for retrieving individual and lists of comments on Forgejo pull requests.
API Key Renaming: Standardized the authentication parameter in ForgejoService from api_key to token for consistency.
New Integration Tests: Added dedicated integration tests for Forgejo issues, covering listing, creation, closing, and assignee management, ensuring the new functionalities work as expected.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request adds support for Forgejo issues, comments, and reactions. The implementation looks good overall, but there are a few issues to address. I've found a critical issue in the test setup that would prevent tests from running, a couple of high-severity bugs in the comments and pull_request modules that would lead to runtime errors or incorrect behavior, and several medium-severity issues related to code clarity, redundancy, and exception handling. Please see my detailed comments for suggestions on how to fix them.

tests/integration/forgejo/base.py

ogr/services/forgejo/comments.py

ogr/services/forgejo/pull_request.py

gemini-code-assist · 2025-12-11T09:41:36Z

ogr/services/forgejo/comments.py

+    def _get_owner_and_repo(self):
+        issue_url = self._raw_comment.issue_url
+        parts = urlparse(issue_url).path.strip("/").split("/")
+        namespace, repo = parts[0], parts[1]
+        return (namespace, repo)


This method _get_owner_and_repo is not used anywhere in the codebase. It should be removed to avoid having dead code.

gemini-code-assist · 2025-12-11T09:41:36Z

ogr/services/forgejo/issue.py

+        except Exception as ex:
+            raise OperationNotSupported(f"Issue {issue_id} not found") from ex


Catching a generic Exception is too broad and can hide other unexpected errors. It's better to catch the specific NotFoundError that pyforgejo is expected to raise when an issue is not found. You are already importing NotFoundError in this file.

Suggested change

except Exception as ex:

raise OperationNotSupported(f"Issue {issue_id} not found") from ex

except NotFoundError as ex:

raise OperationNotSupported(f"Issue {issue_id} not found") from ex

ogr/services/forgejo/issue.py

gemini-code-assist · 2025-12-11T09:41:37Z

ogr/services/forgejo/pull_request.py

        project: "forgejo.ForgejoProject",
    ):
        super().__init__(raw_pr, project)
+        self.project = project


The assignment self.project = project is redundant. The parent class BasePullRequest already initializes self._target_project with the project argument, and provides a project property to access it.

gemini-code-assist · 2025-12-11T09:41:37Z

ogr/services/forgejo/pull_request.py

+                )
+            )
+        except NotFoundError as ex:
+            raise NotFoundError(f"{ex}") from ex


Re-raising NotFoundError with f"{ex}" as the message is redundant, as it just uses the original exception's message. You can simply re-raise the exception to preserve the original traceback and message.

Suggested change

raise NotFoundError(f"{ex}") from ex

raise

gemini-code-assist · 2025-12-11T09:41:37Z

ogr/services/forgejo/pull_request.py

        filename: Optional[str] = None,
        row: Optional[int] = None,
-    ) -> "PRComment":
+    ):


The return type annotation -> "PRComment" was removed from the method signature. It should be restored for type consistency and clarity.

Suggested change

):

) -> "PRComment":

tests/integration/forgejo/test_issues.py

softwarefactory-project-zuul · 2025-12-11T09:57:50Z

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/b6beebb03c6f463ea0cf95e8cd622d57

✔️ pre-commit SUCCESS in 2m 59s
❌ ogr-tests-pip-deps FAILURE in 18m 04s

ogr/services/forgejo/comments.py

ogr/services/forgejo/issue.py

betulependule · 2025-12-12T10:32:49Z

ogr/services/forgejo/issue.py

+            repo=project.repo,
+            title=title,
+            body=body,
+            labels=labels,


The labels parameter of the create_issue method is of the Optional[Sequence[int]] type, but the variable that is passed here is of the type Optional[list[str]]. Some sort of conversion is required here.

The docstring of the create_issue method:

labels : typing.Optional[typing.Sequence[int]] list of label ids

betulependule · 2025-12-15T11:48:54Z

Hi @mynk8, I'm following up on your progress on these Forgejo-related features. Is this something you still plan to work on, or would you like us to step in and finish the rest?

mynk8 · 2025-12-15T12:04:00Z

Hi, thanks for the follow-up. Please feel free to continue and complete the remaining work. I’m currently focused on other things and won’t be able to take this forward right now.

betulependule · 2025-12-15T12:12:12Z

Hi, thanks for the follow-up. Please feel free to continue and complete the remaining work. I’m currently focused on other things and won’t be able to take this forward right now.

Thanks for the quick response. I'll try to finish the remaining parts of this PR, then. Thank you again for your contribution. 🙏

centosinfra-prod-github-app · 2025-12-16T11:13:39Z

Build failed.
https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/packit-service/buildset/c22170d7316142748737bb6508ae3906

✔️ pre-commit SUCCESS in 2m 53s
❌ ogr-tests-pip-deps FAILURE in 17m 55s

centosinfra-prod-github-app · 2025-12-16T11:46:30Z

Build failed.
https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/packit-service/buildset/631c680e73d44eedaaf8f38db8cf94c8

✔️ pre-commit SUCCESS in 2m 49s
❌ ogr-tests-pip-deps FAILURE in 17m 56s

centosinfra-prod-github-app · 2025-12-17T09:48:20Z

Build succeeded.
https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/packit-service/buildset/ac6e847be1d64e84bbe746bf1a2a1e8f

✔️ pre-commit SUCCESS in 3m 22s
✔️ ogr-tests-pip-deps SUCCESS in 18m 10s

centosinfra-prod-github-app · 2025-12-17T10:46:54Z

Build failed.
https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/packit-service/buildset/fda8f5c97c4042c189be5c3dd111d394

❌ pre-commit FAILURE in 2m 45s
✔️ ogr-tests-pip-deps SUCCESS in 18m 04s

centosinfra-prod-github-app · 2025-12-17T11:09:49Z

Build succeeded.
https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/packit-service/buildset/967253f08c4147fd9dea9d634a1f95ef

✔️ pre-commit SUCCESS in 2m 43s
✔️ ogr-tests-pip-deps SUCCESS in 17m 56s

Co-authored-by: Matej Focko <mfocko@users.noreply.github.com>

In order to be able to record tests and make changes to the testing repo (in order to add more tests), the Packit team's testing repo is now in use. Most failing tests have been fixed and tests were edited to reflect the current state of the testing repo.

Added a method for commenting on issues and fixed the retrieval of comments for compatibility with existing code. Added one test to ensure functionality of these edits.

Previously, the raw issue returned by the Forgejo API wasn't assigned inside the close method, meaning the ForgejoIssue instance wasn't updated and accessing the status property led to receiving the outdated "open" value rather than the expected "closed" value.

centosinfra-prod-github-app · 2025-12-19T10:02:18Z

Build succeeded.
https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/packit-service/buildset/1de8bbcac3c14a76bda5f612e5ba7cdf

✔️ pre-commit SUCCESS in 2m 49s
✔️ ogr-tests-pip-deps SUCCESS in 18m 07s

centosinfra-prod-github-app · 2025-12-19T10:32:32Z

Build succeeded.
https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/packit-service/buildset/2527e0bcbd5c415699ff01181fd53154

✔️ pre-commit SUCCESS in 3m 16s
✔️ ogr-tests-pip-deps SUCCESS in 18m 10s

It is now possible to delete reactions on comments. During testing, it has been discovered that whenever the get_reactions method is called on a comment with no reactions, pyforgejo raises ApiError. It has also been discovered that re-recording tests results in ValidationError from pydantic, though this error isn't raised again when re-running tests. Further investigation is required.

centosinfra-prod-github-app · 2025-12-19T12:07:59Z

Build succeeded.
https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/packit-service/buildset/64de4f3897f64413860ab6596e2d5c83

✔️ pre-commit SUCCESS in 3m 05s
✔️ ogr-tests-pip-deps SUCCESS in 18m 08s

mfocko assigned mfocko and betulependule Dec 11, 2025

mfocko marked this pull request as draft December 11, 2025 09:39

usercont-release-bot added this to Packit Kanban Board Dec 11, 2025

github-project-automation bot moved this to new in Packit Kanban Board Dec 11, 2025

gemini-code-assist bot reviewed Dec 11, 2025

View reviewed changes

betulependule reviewed Dec 12, 2025

View reviewed changes

ogr/services/forgejo/comments.py Outdated Show resolved Hide resolved

betulependule reviewed Dec 12, 2025

View reviewed changes

ogr/services/forgejo/comments.py Outdated Show resolved Hide resolved

betulependule reviewed Dec 12, 2025

View reviewed changes

ogr/services/forgejo/issue.py Outdated Show resolved Hide resolved

betulependule reviewed Dec 12, 2025

View reviewed changes

betulependule force-pushed the feat/forgejo/issues branch from 5c3e840 to f7ccdf9 Compare December 16, 2025 11:27

betulependule force-pushed the feat/forgejo/issues branch from 5cc2daf to 8961a0a Compare December 17, 2025 10:51

mynk8 and others added 8 commits December 19, 2025 10:41

Update issue.py

b84f94d

Update ogr/services/forgejo/issue.py

d2c2a41

Co-authored-by: Matej Focko <mfocko@users.noreply.github.com>

WIP: comments and reactions

668d646

comments and reactions

f20ec37

Make it possible to record tests and add current responses

a0f7bcd

Add method to comment on issues, fix retrieval of comments

18a26b6

Added a method for commenting on issues and fixed the retrieval of comments for compatibility with existing code. Added one test to ensure functionality of these edits.

betulependule added 9 commits December 19, 2025 10:41

Add support for Forgejo issue labels

780c4ca

Use partial API where possible

c0b5898

Remove unnecessary API call

b5921c1

Add __str__ method to ForgejoIssue

e7b7141

Raise ForgejoAPIException instead of OperationNotSupported

27883b6

Fix implementation of PR commenting and retrieval of PR comments

aea03c9

Fix assignment of author in ForgejoComment

a36b800

Add ordering of issue comments

6b95c03

Add tests regarding commenting and comment retrieval

bbcb2cf

betulependule force-pushed the feat/forgejo/issues branch from 8961a0a to bbcb2cf Compare December 19, 2025 09:43

Implement support for editing comments, add relevant tests

0f49ea8

betulependule added 2 commits December 19, 2025 12:36

Update the __all__ variable of the forgejo module

3225371

		except Exception as ex:
		raise OperationNotSupported(f"Issue {issue_id} not found") from ex

[feat] Forgejo issues and comment / reactions #959

Are you sure you want to change the base?

[feat] Forgejo issues and comment / reactions #959

Uh oh!

Conversation

mfocko commented Dec 11, 2025 • edited by betulependule Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist bot commented Dec 11, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gemini-code-assist bot Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gemini-code-assist bot Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

softwarefactory-project-zuul bot commented Dec 11, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

betulependule Dec 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

betulependule commented Dec 15, 2025

Uh oh!

mynk8 commented Dec 15, 2025

Uh oh!

betulependule commented Dec 15, 2025

Uh oh!

centosinfra-prod-github-app bot commented Dec 16, 2025

Uh oh!

centosinfra-prod-github-app bot commented Dec 16, 2025

Uh oh!

centosinfra-prod-github-app bot commented Dec 17, 2025

Uh oh!

centosinfra-prod-github-app bot commented Dec 17, 2025

Uh oh!

centosinfra-prod-github-app bot commented Dec 17, 2025

Uh oh!

centosinfra-prod-github-app bot commented Dec 19, 2025

Uh oh!

centosinfra-prod-github-app bot commented Dec 19, 2025

Uh oh!

centosinfra-prod-github-app bot commented Dec 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mfocko commented Dec 11, 2025 •

edited by betulependule

Loading

betulependule Dec 12, 2025 •

edited

Loading