Skip to content

Handle single Jira, single patch, multiple CVE commits#631

Open
antbob wants to merge 1 commit into
packit:mainfrom
antbob:one_backport_many_cves
Open

Handle single Jira, single patch, multiple CVE commits#631
antbob wants to merge 1 commit into
packit:mainfrom
antbob:one_backport_many_cves

Conversation

@antbob

@antbob antbob commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

Sometimes we get single Jira, single patch backports that bundle multiple CVEs together as opposed to the regular/standard with one CVE per Jira issue approach. Note that i'm piggybacking on the "cve_id" field here for this which perhaps is not the cleanest solution but it avoids larger refactoring changes. It should be ok as this is not exactly an API and the model is given a clear guidance, examples, and logic on how to do it. Also note that i've tested this with backport only (real backport, real Jira issue) but not other resolution types as we're currently not running rebase and rebuild agents and don't have any such Jiras to test those types on.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for handling multiple CVE IDs within a single Jira issue across triage prompts, schemas, and the git log search tool. The git_log_search tool was updated to extract multiple CVEs and search for them using multiple --grep arguments. However, the current implementation of the search tool and its corresponding test case incorrectly returns a positive match if only one of the multiple CVEs is found, because git log ORs multiple --grep patterns by default. The feedback suggests correcting the test case assertion to expect no matches when some CVEs are missing.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread ymir/tools/unprivileged/tests/unit/test_wicked_git.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant