-
Notifications
You must be signed in to change notification settings - Fork 31
Sync reqs #578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jpodivin
wants to merge
3
commits into
packit:main
Choose a base branch
from
jpodivin:sync_reqs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Sync reqs #578
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -28,11 +28,12 @@ RUN git config --global user.email "ymir-tests@example.com" \ | |
| # Set PYTHONPATH so ymir namespace package can be imported | ||
| ENV PYTHONPATH=/src:$PYTHONPATH | ||
|
|
||
| # Install BeeAI Framework and FastMCP | ||
| # Copy dependency file | ||
| COPY requirements-base.txt /tmp/ | ||
|
|
||
| # Install BeeAI Framework | ||
| RUN pip3 install --no-cache-dir \ | ||
| "litellm!=1.82.7,!=1.82.8" \ | ||
| beeai-framework[vertexai,mcp,duckduckgo]==0.1.79 \ | ||
| fastmcp redis backoff | ||
| -r /tmp/requirements-base.txt | ||
|
Comment on lines
+34
to
+36
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
We should add |
||
|
|
||
| # Verify no malicious litellm_init.pth was introduced by compromised litellm packages (e.g. 1.82.7, 1.82.8) | ||
| RUN MALICIOUS=$(find /usr /opt -name "litellm_init.pth" 2>/dev/null); \ | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| # Agent container dependencies (c9s, c10s) | ||
| -r requirements-base.txt | ||
| google-cloud-aiplatform | ||
| aiohttp>=3.12.15 | ||
| koji | ||
| GitPython>=3.1.0 | ||
| unidiff | ||
| sentry-sdk>=2.13.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| # Shared pip dependencies for all containers (except MCP) | ||
| # Prevent installation of compromised litellm package versions | ||
| litellm!=1.82.7,!=1.82.8 | ||
| beeai-framework[vertexai,mcp,duckduckgo]==0.1.80 | ||
| openinference-instrumentation-beeai | ||
| arize-phoenix-otel | ||
| redis>=6.4.0 | ||
| specfile>=0.36.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| # Dependencies for the MCP gateway container (beeai[mcp] only, no vertexai/duckduckgo) | ||
| litellm!=1.82.7,!=1.82.8 | ||
| beeai-framework[mcp]==0.1.80 | ||
| specfile>=0.36.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| # Supervisor container dependencies | ||
| -r requirements-base.txt | ||
| google-cloud-aiplatform |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| # c9s test container dependencies | ||
| -r requirements-base.txt | ||
| aiohttp>=3.12.15 | ||
| koji | ||
| GitPython>=3.1.0 | ||
| pytest | ||
| pytest-asyncio | ||
| flexmock>=0.12.2 | ||
| tomli-w |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The build dependencies (
gcc,gcc-c++,python3-devel) are currently installed and immediately removed in the firstRUNinstruction, beforepip3 installis executed in a separate layer. This means these build tools are not available whenpip3 installruns, which will cause installation failures if any package or its dependencies require compilation. Additionally, installing and removing them in the first layer without using them is redundant.To fix this, we should copy the requirements files first, and then install the build tools, run
pip3 install, and clean them up all within the sameRUNinstruction to keep the image size small.