Adds freeze and unfreeze functionality#507
Adds freeze and unfreeze functionality#507g-abilio wants to merge 17 commits intopaceholder:masterfrom
Conversation
Integrate upstream
g-abilio
changed the title
|
Just like in the PR #509 I removed the unnecessary code that only implemented an example of the Freeze feature's usage, that included creating a menu and incrementing the contextMenuEvent, just like in the other Pull Request mentioned. In this case, the feature's API was also tested in one of our applications at @fabns-nano and everything worked perfectly! |
tatatupi
left a comment
tatatupi
left a comment
There was a problem hiding this comment.
Ideally, in the example, when the change is made but the output is frozen, the status icon should reflect a warning sign.
| std::shared_ptr<NodeData> MathOperationDataModel::outData(PortIndex) | ||
| { | ||
| return std::static_pointer_cast<NodeData>(_result); | ||
| auto output = std::static_pointer_cast<NodeData>(_result); |
There was a problem hiding this comment.
Is this change really necessary?
There was a problem hiding this comment.
No! A commit that removed those changes has already been made. Thanks for noticing!
Currently, using this feature in an application at @fabns-nano, this is the behavior. Now, considering the removal of the example implementation from this PR, this behavior (change of the processing status icon) depends on how developers use the API. |
3 participants
Type of change
Description
This PR adds the option to freeze the node, that is the output will no longer be propagated. A demonstration of this functionality can be seen in the video below:
freeze_demo.mp4
The feature is triggered via setter method, and the example of the functionality can be found in the Random Number node.
Testing