Feat/move to poetry#470
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Thank you for the PR @martynvdijke. It would be great to use tilde specification to specify the dependency. That way we can still get minor updates for those libraries. |
|
Thanks @martynvdijke I will review this soon! |
|
@martynvdijke thank you for the PR. This looks great to me, I will test this a bit more locally and merge this soon! |
|
@tushar5526 any update on this ? |
|
Hey hey @tushar5526 I guess you are busy, no worry on that any update on the PR ? |
|
Hey @martynvdijke ,sorry as I have not been able to find much time (lots of stuff going on rn) I will try to share feedback with you this weekend. Thank you for your patience :) |
|
No worries, take your time just checking in :) |
| pyopengl-accelerate = "^3.1.7" | ||
| pyopengl = "^3.1.6" | ||
| requests = "^2.25.0" | ||
| numpy = [ |
There was a problem hiding this comment.
In the requirements.txt numpy is not tagged to a specific version (which is a bad practice already)
I appreciate you pinning the version, but why different versions are pinned for different python version?
There was a problem hiding this comment.
This is needed because numpy version 1.21 is the last version that is python3.7 compatible.
Otherwise poetry can not figure out the dependency for python 3.7 if that makes sense ?
So by pinning it like this we can ensure compatibility on python3.7 and have a more up to date version for the python versions above.
|
|
||
| [tool.poetry.dependencies] | ||
| python = "^3.7" | ||
| freetype-py = "^2.1.0" |
There was a problem hiding this comment.
Why freetype-py is added a direct dependency?
| skia-python = "^87.5" | ||
|
|
||
|
|
||
| [tool.poetry.group.dev.dependencies] |
There was a problem hiding this comment.
Why different dependency versions are pinned for different python versions?
There was a problem hiding this comment.
Same reason as above otherwise poetry can figure out which dependencies to use for older python versions.
Since they cannot run the newest version on the older pytthon versions
|
@martynvdijke , again thanks for your PR and patience. I have left some comments. I think we can also remove the requirements.txt file if there are no dependency on it. |
|
@tushar5526 I had a look at the comments and update and explained to your comments |
2 participants
Hey all,
Just found this repo while searching for the docs I saw that #464 was still hanging.
So decided to fix that, this introduced poetry as a dependency management tool.
It should also add the pylint configuration as a setting file.