Move Bazel workspace root to project root#573
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
smolkaj
left a comment
smolkaj
left a comment
There was a problem hiding this comment.
LGTM. @matthewtlam, would you also be able to review?
matthewtlam
left a comment
matthewtlam
left a comment
There was a problem hiding this comment.
LGTM overall. Thanks Jules!
|
Discussed at P4 API WG meeting just now. AIs: Try to add deprecation notice to the aliases. |
Added deprecation notice to all aliases. |
…ventions. This also includes defining Bazel build targets in BUILD.bazel files in the same directories as the source files. We declare build target aliases with a deprecation notice, so users depending on P4Runtime should not have to update their BUILD rules but are nudged in the right direction. Fixes #571. Signed-off-by: smolkaj <smolkaj@google.com>
smolkaj
force-pushed
the
move-bazel-root-3243768557642822763
branch
from
42cbaf6 to
b688ad2
Compare
|
@chrispsommers PTAL. Ready to merge from my side. |
3 participants
This change moves the Bazel workspace root from the
proto/directory to the repository root, resolving issue #571. This aligns the project structure with standard Bazel practices and simplifies usage for consumers.Changes:
proto/MODULE.bazel,proto/WORKSPACE.bazel,proto/.bazelrc,proto/WORKSPACE.bzlmod, andproto/p4runtime_deps.bzlto the repository root.BUILD.bazelfile.proto_librarytargets inproto/BUILD.bazelto includestrip_import_prefix = "/proto", ensuring import paths likep4/config/v1/...continue to work correctly.bazel/example/using-workspace/BUILD.bazelandbazel/example/using-bzlmod/BUILD.bazelto reference@com_github_p4lang_p4runtime//proto:p4info_cc_protoinstead of the root package.bazel/example/using-workspace/WORKSPACE.bazelandbazel/example/using-bzlmod/MODULE.bazelto pointlocal_repository/local_path_overrideto the repo root and removed thestrip_prefixworkaround.Verified by building
//proto/...and the example projects//bazel/example/....PR created automatically by Jules for task 3243768557642822763 started by @smolkaj