Merged
Conversation
Contributor
Reviewer's Guide by SourceryThis pull request introduces simpler constructors for No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey @p14n - I've reviewed your changes - here's some feedback:
Overall Comments:
- The README example for LocalPersistentConsumer appears to use a different constructor signature than the one added in the code.
- The new constructors implicitly create a DataSource; consider if users might want to provide their own existing DataSource instance for more flexibility.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| Tested on fargate 0.5vCPU/1GB with RDS db.t4g.micro | ||
| - Throughput: 200 events/second | ||
| - Latency: Y ms average | ||
| - Latency: < 50ms ms from topic publish to remote client receive in transaction |
Contributor
There was a problem hiding this comment.
issue (typo): Typo: Duplicate 'ms' unit.
Remove the extra 'ms' unit.
Suggested change
| - Latency: < 50ms ms from topic publish to remote client receive in transaction | |
| - Latency: < 50ms from topic publish to remote client receive in transaction |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Introduce simpler constructors for
LocalPersistentConsumerandConsumerServerwhich automatically configure database connections and executors.Enhancements:
LocalPersistentConsumerandConsumerServerthat create and manage default database connection pools and executors based on the provided configuration.Documentation:
LocalPersistentConsumer.