Open
Conversation
Owner
|
Thanks @NielsRogge for you inputs! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Thanks for this interesting work. I contributed YOLOS back in the day to the Transformers library, so it's nice to see you're leveraging it here. Since you do seem to use this model, and not the YOLO model from Ultralytics, I assume we can update the link in the README (and perhaps as well the mention in the paper, which mentions YOLO instead of YOLOS).
Next to that, I see you leverage CLIPCount, it would be nice to make this model available on 🤗 for easy inference, and better discoverability. Here's how it can be used:
This way, people also don't need to manually download the checkpoint, it loads automatically from the hub.
Moreover, it leverages safetensors for serialization rather than pickle, which is considered unsafe.
Would you be interested in this integration?
Cheers,
Niels
Open-source @ HF
Note
Please don't merge this PR before pushing and reloading :)