uses exec to start serving from entrypoint#42
Open
mhrivnak wants to merge 1 commit intooxtyped:mainfrom
Open
Conversation
Previously, the entrypoint script left a shell process running forever,
consuming some modest resources. This change uses `exec` to ensure that
the gpodder2go process replaces the shell process, which is a best
practice for containerization.
You can see a `sh` process running alongside `gpodder2go`:
```
[mhrivnak@roadie ]$ podman ps
CONTAINER ID IMAGE COMMAND CREATED STATUS PORTS NAMES
9ca019f13341 ghcr.io/oxtyped/gpodder2go:main 18 seconds ago Up 18 seconds 3005/tcp gpodder2go
[mhrivnak@roadie ]$ podman exec -it gpodder2go ps -Af
PID USER TIME COMMAND
1 root 0:00 {entrypoint.sh} /bin/sh /entrypoint.sh
13 root 0:00 /gpodder2go serve --addr 0.0.0.0:3005
19 root 0:00 ps -Af
```
after this change, the shell process is gone:
```
[mhrivnak@roadie ]$ podman ps
CONTAINER ID IMAGE COMMAND CREATED STATUS PORTS NAMES
1c33ba12b5a5 localhost/gp2g:latest 10 seconds ago Up 11 seconds 3005/tcp gpodder2go
[mhrivnak@roadie gpodder2go-container]$ podman exec -it gpodder2go ps -Af
PID USER TIME COMMAND
1 root 0:00 /gpodder2go serve --addr 0.0.0.0:3005
18 root 0:00 ps -Af
```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the entrypoint script left a shell process running forever, consuming some modest resources. This change uses
execto ensure that the gpodder2go process replaces the shell process, which is a best practice for containerization.You can see a
shprocess running alongsidegpodder2go:after this change, the shell process is gone: