Make sure we still do writeback on test failure#10097
Draft
Conversation
smklein
commented
Mar 19, 2026
| // process has exited. This lets us poll with a | ||
| // timeout and fall back to SIGKILL. | ||
| let deadline = std::time::Instant::now() | ||
| + std::time::Duration::from_secs(5); |
Collaborator
Author
There was a problem hiding this comment.
Open for discussion on how long this should plausibly be. Could be forever, if we don't want to have the SIGKILL fallback below!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses SIGTERM for
CockroachInstancesthat are dropped without being cleaned, to propagate ongoingwrites back to durable storage for inspection.
Additionally, adds a test which validates this behavior (torn writes should no longer appear with the new SIGTERM-on-drop implementation).
Fixes #10085