allow different path param names across API versions#1567
Open
sunshowers wants to merge 2 commits intomainfrom
Open
allow different path param names across API versions#1567sunshowers wants to merge 2 commits intomainfrom
sunshowers wants to merge 2 commits intomainfrom
Conversation
Created using spr 1.3.6-beta.1
sunshowers
commented
Mar 10, 2026
Comment on lines
-679
to
-683
| Some(HttpRouterEdges::VariableRest(varname, node)) => { | ||
| Box::new(std::iter::once(( | ||
| PathSegment::VarnameSegment(varname.clone()), | ||
| node, | ||
| ))) |
Contributor
Author
There was a problem hiding this comment.
My understanding is that this should have been VarnameWildcard -- fixed and included a test for this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Across API versions we now allow path parameters to have different names.
Within the same API version, we continue to require them to be named the same for consistency.
Fixes #1566.