Skip to content

Add crucible-verify-raw and crucible-raw-extent packages#1800

Merged
mkeeter merged 1 commit intomainfrom
mkeeter/verify-raw
Oct 27, 2025
Merged

Add crucible-verify-raw and crucible-raw-extent packages#1800
mkeeter merged 1 commit intomainfrom
mkeeter/verify-raw

Conversation

@mkeeter
Copy link
Contributor

@mkeeter mkeeter commented Oct 23, 2025

This PR extracts the crucible-verify-raw tool from #1791. The on-disk data structures for raw extents are moved to a new crucible-raw-extent package, which is used by both crucible-downstairs and crucible-verify-raw.

@mkeeter mkeeter requested a review from jmpesp October 23, 2025 21:26
@mkeeter mkeeter assigned leftwo and unassigned leftwo Oct 23, 2025
@mkeeter mkeeter requested a review from leftwo October 23, 2025 21:26
@mkeeter mkeeter force-pushed the mkeeter/verify-raw branch from 16cca92 to ce1b855 Compare October 24, 2025 13:58
@leftwo
Copy link
Contributor

leftwo commented Oct 26, 2025

I was thinking about the "one binary to rule them all" vs. having separate tools.

Having one binary means it's already available on the sled, which I liked, and if we did not make it part of crucible-downstairs, we would have to add framework to build and install the new binary into the image so we would have it installed without having to copy it in from outside the rack.

However, it's actually not that hard to solve this another way. We already have the crucible-dtrace package that is part of every global zone, so we can stuff these tool binaries in this same package without too much additional work.

@mkeeter mkeeter force-pushed the mkeeter/verify-raw branch from ce1b855 to 7e9c587 Compare October 27, 2025 15:17
@mkeeter mkeeter marked this pull request as ready for review October 27, 2025 15:17
@mkeeter
Copy link
Contributor Author

mkeeter commented Oct 27, 2025

@leftwo maybe we should rename it crucible-utils instead of crucible-dtrace?

@leftwo
Copy link
Contributor

leftwo commented Oct 27, 2025

@leftwo maybe we should rename it crucible-utils instead of crucible-dtrace?

Yeah, it's now becoming more that just DTrace. I have other things I want to stuff in there as well that are more "tools" than specific DTrace scripts.

@mkeeter mkeeter merged commit 3b6819c into main Oct 27, 2025
17 checks passed
@mkeeter mkeeter deleted the mkeeter/verify-raw branch October 27, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants