Add crucible-downstairs validate subcommand#1792
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new verify subcommand to crucible-downstairs that validates the integrity of region data by checking that block hashes match their stored context slots.
Key Changes:
- Adds
verifysubcommand to thecrucible-downstairsCLI - Implements validation logic for raw extents that compares block data hashes against stored context slots
- Validates in parallel using rayon for improved performance
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| downstairs/src/main.rs | Adds Verify subcommand enum variant and routes it to verify_region function |
| downstairs/src/lib.rs | Exports new verify_region function from dump module |
| downstairs/src/extent.rs | Adds validate trait method and public wrapper for extent validation |
| downstairs/src/extent_inner_raw.rs | Implements validation logic for raw extents by reading and hashing blocks in bulk |
| downstairs/src/extent_inner_sqlite.rs | Stubs out unimplemented validation for Sqlite extents |
| downstairs/src/dump.rs | Implements verify_region function with parallel validation using rayon |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
db67a9f to
13b1577
Compare
jmpesp
approved these changes
Oct 15, 2025
leftwo
approved these changes
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a spin-off from #1791; it adds validation to
crucible-downstairsbut does not validate extent after receiving them during repair operations.