Conversation
Search improvements: - Silos: fix multi-page search - Silo Images: add search - Projects: fix multi-page search - Project Instances: fix multi-page search - Project VPCs: fix multi-page search - Project IP Pools: fix multi-page search - Project Floating IPs: add search - Project Images: add search Add buttons to cmd-k: - Project Affinity: "New Group" - Project Access: "Add user or group" - Project Disks: "New disk" - Project Floating IPs: "New Floating IP" - Project Images: "Upload Image" - Project Snapshots: "New Snapshot" - Project VPC: "New VPC" - Silo Access: "Add user or Group" - Silo Images: Add "Promote image"
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
I will review in more detail, but it all looks solid at first glance. We were already tracking some of these issues in #1352, so thanks for fixing them! |
| [] | ||
| ) | ||
| ) | ||
|
|
There was a problem hiding this comment.
There was a problem hiding this comment.
Oh and it's janky if you click the background because that only affects the form, so you close the form but not the ctrl-k popup. Out of scope for this PR, just noting it.
| })), | ||
| ], | ||
| [navigate, silos] | ||
| [navigate, allSilos] |
There was a problem hiding this comment.
We need to make sure this hook behaves correctly when the silos request comes back (the old one would have been prefetched). I'm pretty sure it does — that's the point of this remove callback. On every re-run of the effect, we remove whatever the last one added before adding the new items.
I would leave this one not-prefetched, as you've done. Since quick actions are hidden until the user opens the menu, it's the perfect thing to defer.
console/app/hooks/use-quick-actions.tsx
Lines 91 to 106 in b43b995

I was initially excited about using
cmd-kto navigate the UI with the keyboard but immediately ran into some limitations and so took a stab at improving them.This is my first PR to oxidecomputer/console and was Claude assisted.
I have tested locally and verified these changes seem to work as expected. (see images in #3128)
If this is the wrong approach / redundant, feel free to summarily close.