Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
After refactors at the end of #3057, there wasn't much left of `IpPoolSelector`, so I intended to remove it. Essentially all it did was sort the pools, which we can do at the call sites. Removing it is a net -40 line change with no loss of functionality.
david-crespo
force-pushed
the
system_level_access_page
branch
from
c25e248 to
6941cd4
Compare
david-crespo
force-pushed
the
system_level_access_page
branch
from
6941cd4 to
f57ec49
Compare
Collaborator
|
2cba589 is this 
|
Collaborator
|
I'm happy with this. I like the "Any" to avoid the misreading that there is exactly one silo admin in whatever silo. 9429b8a makes sure we fall back to the ID instead of an empty cell when the assigned entity is not in the current user's silo (which is entirely possible with the fleet policy). 
|
david-crespo
force-pushed
the
system_level_access_page
branch
from
5489ef7 to
9429b8a
Compare
david-crespo
approved these changes
Mar 10, 2026
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Mar 13, 2026
oxidecomputer/console@d8e6a70...41d066c * [41d066cc](oxidecomputer/console@41d066cc) oxidecomputer/console#3123 * [4f6a2fd8](oxidecomputer/console@4f6a2fd8) oxidecomputer/console#3119 * [1713e534](oxidecomputer/console@1713e534) oxidecomputer/console#3095 * [6c1178e8](oxidecomputer/console@6c1178e8) oxidecomputer/console#3116 * [863f869c](oxidecomputer/console@863f869c) oxidecomputer/console#3114
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Mar 13, 2026
oxidecomputer/console@d8e6a70...41d066c * [41d066cc](oxidecomputer/console@41d066cc) oxidecomputer/console#3123 * [4f6a2fd8](oxidecomputer/console@4f6a2fd8) oxidecomputer/console#3119 * [1713e534](oxidecomputer/console@1713e534) oxidecomputer/console#3095 * [6c1178e8](oxidecomputer/console@6c1178e8) oxidecomputer/console#3116 * [863f869c](oxidecomputer/console@863f869c) oxidecomputer/console#3114
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a system-level access page, with a form for setting fleet-level permissions.
One enhancement we might consider: It looks like there are a few booleans —
silo_adminandfleet_viewer— on the CurrentUser object coming from Omicron, but there is not afleet_adminattribute. If we add that in Omicron, we could disable the "Add User or Group" button and other controls on the System Access page for people without a fleet_admin role.Closes #2916