Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now Buildomat only allows specifying AWS credentials by writing the access key in the configuration file (of both the server and the AWS factory). That requires creating an IAM User with persistent credentials, which is not great (I'd like to avoid having credentials laying around in my disk).
This PR changes the way AWS credentials are loaded from the configuration:
profilesetting is present instead ofaccess_key_idandsecret_access_key, the AWS SDK will use its default credential chain to load the credentials from that profile. This is what I'd use on my developer machine to connect to my sandbox AWS account, with AWS SSO.On the implementation side, I preferred extracting the logic into a new
aws-commoncrate rather than duplicating it between the server and the AWS factory. I didn't put it in thecommoncrate because then everything would depend on the AWS SDK.