🐛 Version no longer prints 0.0.0 #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f907cc9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Curvenote Preview 📭 No submissions available to inspect. |
rowanc1
commented
Dec 24, 2025
| "changelog": ["@changesets/changelog-github", { "repo": "oxa-dev/oxa" }], | ||
| "commit": false, | ||
| "fixed": [], | ||
| "fixed": [["@oxa/core", "oxa"]], |
Member
Author
There was a problem hiding this comment.
Linking these @nokome.
I assume the types are linked in different ways.
rowanc1
commented
Dec 24, 2025
Comment on lines
+19
to
+20
| "copy:version": "echo \"const version = '\"$npm_package_version\"';\nexport default version;\" > src/version.ts", | ||
| "build": "pnpm run copy:version && tsc && cp ../../schema/schema.json dist/ && pnpm run build:bundle", |
Member
Author
There was a problem hiding this comment.
Export a version.ts, which is git-ignored. Then import that in code rather than looking to the package.json which failed when I was using it as a stand-alone bin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was falling through to the 0.0.0 for the CLI side, this bakes in the version in code rather than looking up and reading the package.json.