Conversation
|
Salipa-Gurung
approved these changes
Aug 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the scribbles for the dicom viewer app we had been using an icon for the flip image functionality that was not part of the remix icon set (the icon set didn't offer any icon for this purpose at that time). In the meanwhile the publishers of the remix icon set have added such an icon as suggested by us. In fact, they have even provided 2 variants (see Remix-Design/RemixIcon#650 (comment)). In this PR we have updated the icon to the one that was initially used in the scribbles.
Related Issue
Motivation and Context
make UI more intuitive by using suitable, less ambiguous icons
Screenshots (if appropriate):
Types of changes
Checklist: