Create tracing.adoc#1212
Conversation
added an end to end document for tracing with Otel
|
@Rajakavitha1 many thanks for this PR, much appreciated. We have a deployment example Local Production Setup where the description is located in |
Just incorporated the changes that. you suggested in #1213 |
added note about signoz cloud endpoint
DeepDiver1975
left a comment
There was a problem hiding this comment.
🤖 Automated review by Claude Code review agent.
Thanks for documenting an end-to-end oCIS → SigNoz tracing workflow — the structure is clear and the step-by-step flow (prerequisites → enable → start → verify → generate traffic) reads well. I do, however, see some blocking issues around file placement / nav wiring and technical accuracy against the upstream ocis_full example that should be resolved before merge.
Overview
- Single new file:
modules/ROOT/pages/monitoring/tracing.adoc(233 lines), targetingmaster. - Addresses issue #526. Author reports local testing with screenshots.
Blocking issues
1. Wrong module — file is placed in ROOT, not admin
All monitoring documentation lives in the admin component, not ROOT. The existing page is modules/admin/pages/monitoring/prometheus.adoc, and ROOT is just an index shell. Tellingly, prometheus.adoc carries:
:page-aliases: ROOT:monitoring/prometheus.adoc
i.e. monitoring content was deliberately moved out of ROOT into admin, leaving the old ROOT:monitoring/... path only as a redirect alias. This PR puts a new page back into that deprecated location.
Suggested fix: move the file to modules/admin/pages/monitoring/tracing.adoc.
2. Not wired into the navigation
The page is not referenced from any nav.adoc, so it will not appear in the site navigation. The Monitoring section is in modules/admin/partials/nav.adoc (around line 96):
** Monitoring
*** xref:admin:monitoring/prometheus.adoc[Prometheus]
Suggested fix: add a sibling entry, e.g.:
*** xref:admin:monitoring/tracing.adoc[Tracing]
3. Technical accuracy — commands/paths don't match the upstream ocis_full example
I checked owncloud/ocis@master:deployments/examples/ocis_full. Several referenced paths/files do not exist there, so a reader following this guide verbatim will hit errors:
observability.compose.ymldoes not exist inocis_full. Step 3 instructsdocker compose -f observability.compose.yml up -d. The example only shipsdocker-compose.yml(plusmonitoring_tracing/*.ymlincludes).monitoring_tracing/signoz/deploy/dockerdoes not exist. Step 1'scd ~/ocis-stable-7.2/.../monitoring_tracing/signoz/deploy/dockerpoints to a directory that isn't in the example.monitoring_tracing/contains only:empty_dummy.yml,m_collaboration-oo.yml,m_collaboration.yml,monitoring.yml,tracing_env.yml.monitoring.ymlis not a flat env file. Step 2 says "Editmonitoring.ymland ensure the following tracing configuration is present" with bare keys (OCIS_TRACING_ENABLED: "true", etc.). In realitymonitoring.ymlis a Compose file (services:/networks:/include:) thatextendstracing_env.yml. The tracing env vars actually live intracing_env.yml, and the upstream default endpoint isOCIS_TRACING_ENDPOINT: jaeger:4317— notsignoz-otel-collector:4317. So the instruction to editmonitoring.ymldirectly is incorrect for the shipped example.
If this PR documents a custom SigNoz setup you assembled locally (which the screenshots suggest), the guide should either (a) include/contribute the missing SigNoz compose assets to the ocis repo and reference them accurately, or (b) clearly state these files/dirs must be created by the reader and show their contents. As written it reads as if these already exist in ocis_full, which they do not.
Code quality / style (AsciiDoc / Antora)
- Horizontal rule
---: the file uses Markdown-style---as section separators. In AsciiDoc that is not a thematic break (which is'''); a bare---line is rendered as literal text / can start an open block. Recommend removing them (Antora pages typically rely on section headings for separation) or use'''if a rule is truly wanted. - Missing page header attributes. Compare to
prometheus.adoc, which sets:toc: right,:description: ..., and:page-aliases:. Recommend adding at least:toc:and:description:for consistency and SEO/search. - Placeholder consistency.
<name of the container>(step 4) vs<nameof the container>(step 5, missing space). Pick one consistent placeholder, e.g.<ocis-container-name>, and ideally show how to obtain it (docker compose ps). - Bare URLs as listings.
http://localhost:8080is shown inside----literal blocks. Consider inline monospace (http://localhost:8080) or a proper link; a listing block here is heavier than needed. - No
xreflinks. The page does not cross-reference related docs (e.g. the Prometheus monitoring page or the deployment-examples pages). Adding an xref to theocis_fullexample would help readers and is the house style. - Title length/scope. PR title is "Create tracing.adoc" but the page title is very specific ("...to SigNoz using Docker Compose"). That's fine, but consider a more general H1 (e.g. "Tracing") with SigNoz as a subsection, since the nav label will likely be "Tracing".
Specific suggestions
- Use the example IP convention consistently — the doc uses
192.0.2.24(TEST-NET-1), which is good for docs; keep that. - Step 5:
ncmay not be present in the oCIS container image; consider noting a fallback (e.g.getent hostsalone, or awget/curlprobe) in casencis unavailable. - Add a short troubleshooting note: if traces don't appear, check
docker logsof the otel-collector and confirmOCIS_TRACING_ENDPOINTmatches the collector's service name on the sharedocis-netnetwork.
Potential issues / risks
- Highest risk: because of the wrong module path + missing nav entry, this page will not be discoverable on the built site even if merged.
- Reader-breaking: the non-existent
observability.compose.ymlandsignoz/deploy/dockerpath, plus editingmonitoring.ymldirectly, mean the documented happy path cannot be followed against the current upstream example. This is the most important correctness item to reconcile. - Version pinning: instructions hard-code
~/ocis-stable-7.2/.... Antora has attributes for versioned paths (seeantora.yml, e.g.ocis_repo_url_stable). Hard-coded7.2will rot; consider attribute-based or version-neutral paths.
Net: solid first draft of a genuinely useful guide. Please (1) move to modules/admin/pages/monitoring/tracing.adoc, (2) add the nav entry, (3) reconcile the SigNoz commands/paths with what actually ships in ocis_full (or contribute the missing assets), and (4) align AsciiDoc syntax/header attributes with prometheus.adoc.
added an end to end document for tracing with Otel
addresses: #526
I tested and validated the instructions that are documented in this PR:

