fix: recalculate grid span count after rotation#4894
Conversation
|
Hi @himu-gupta! Thanks for opening this PR! 🙌🏻 Some improvements here before the CR:
Let us know if you have any doubts and we will help you! I will start with the code review when all changes are done 🍻 |
4a35526 to
bc59543
Compare
Signed-off-by: Himanshu Gupta <himu.gupta23@gmail.com>
Signed-off-by: Himanshu Gupta <himu.gupta23@gmail.com>
bc59543 to
c889d0b
Compare
Thanks @joragua, I have done the requested changes. |
|
Thanks for your contribution @himu-gupta!! Let me tell you how the process is. Basically, there are two phases after the PR is correct (signed commits, separated changelog, conventional commits correct...):
For sure, all CI checks must be green as well, otherwise merging will be blocked. Code review will start soon, keep tuned!! |
Thanks for the insight |
|
@joragua is anything pending from my end? |
|
I'll take care of it as soon as possible and I'll ping you once the CR is ready! Stay tuned! 🙌🏻 @himu-gupta |
joragua
left a comment
There was a problem hiding this comment.
CR finished! 🚀 Some comments here @himu-gupta
Signed-off-by: Himanshu Gupta <himu.gupta23@gmail.com>
Signed-off-by: Himanshu Gupta <himu.gupta23@gmail.com>
|
Thanks @joragua, addressed the CR in two new commits on top without force-pushing: |
joragua
left a comment
There was a problem hiding this comment.
Just two easy comments and it's ready! Thanks for your patience @himu-gupta!
Would it be possible to squash the two commits about calens into a single one? We use to have only one commit for the calens entry in each PR. Also, I'd rename the last commit to make it more descriptive. The idea would be to have only three commits in this PR:
fix: recalculate grid span count after rotationchore: add calens filerefactor: remove unnecessary grid recalculation logic
| The grid mode column count has been recalculated after device rotation, keeping | ||
| file tiles in the correct layout for the new orientation. |
There was a problem hiding this comment.
I'd re-write the description like this:
| The grid mode column count has been recalculated after device rotation, keeping | |
| file tiles in the correct layout for the new orientation. | |
| The grid mode column count has been recalculated after device rotation, keeping | |
| file layouts aligned with the new orientation. |
Summary
Fixes #4884
Verification
JAVA_HOME="/Applications/Android Studio.app/Contents/jbr/Contents/Home" ANDROID_HOME="/Users/himu/Library/Android/sdk" ./gradlew --no-daemon --console=plain :owncloudApp:compileOriginalDebugKotlingit diff --check