Convert audio names to md5 digest - WIP#72
Convert audio names to md5 digest - WIP#72akilegaspi wants to merge 0 commit intoowickstrom:masterfrom
Conversation
|
Still have to create automated tests for this one also |
There was a problem hiding this comment.
Thanks for submitting a PR! Some comments on the changes:
- We should hash the audio file contents to calculate audio chunk file names
- I'd recommend using
cryptoniteand itshashlazyfunction together with a lazy ByteString read
- I'd recommend using
- The non-classifying copy should also copy to a hashed name:
Regarding tests, it would be very nice if you'd add something! 👏
Thanks!
|
Sorry, I haven't been able to checkout the PR for awhile now but ok, so if I understood it correctly, we use the contents of the file to create a hashname for the audio chunk. Also what do you mean by "non-classifying copy?" |
|
@owickstrom In accordance with #76 , I think it would be better if we created a helper module for generating a hash given With that being said, it would be easier for us to create tests (using QuickCheck maybe?) for our respective What do you think? |
|
@akilegaspi feel free to help out with the helper function, I started making something but I'm using the file name to do the hashing when I think from comments we need to use the file content? https://github.com/owickstrom/komposition/pull/76/files#diff-c0ab36ff8cac8d74b3774e1a4cb62225 |
Description: Extracts the base name of the audio file and transforms the base name into an md5 digest
This pull requests fixes #25, by @owickstrom
Make sure to describe (where applicable):
pureMD5-2.1.3PackagebytestringPackageChecklist:
Please make sure to check the following items (that are applicable.)
How to test:
TODO: Testing instructions for reviewer.