Fix assertion failure when updating framebuffers of type 2D array#2076
Open
Hanicef wants to merge 1 commit intooverte-org:masterfrom
Open
Fix assertion failure when updating framebuffers of type 2D array#2076Hanicef wants to merge 1 commit intooverte-org:masterfrom
Hanicef wants to merge 1 commit intooverte-org:masterfrom
Conversation
Member
|
Thank you! We should look into this together and fix shadows on Vulkan as soon as the grant is over. |
Member
|
Could you rebase this on master to avoid the CI pipeline failing? |
Hanicef
force-pushed
the
fix-2d-array-framebuffer
branch
from
48d788e to
5b68cb2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VKFramebufferwas missing a case forVK_IMAGE_VIEW_TYPE_2D_ARRAYthat would cause crashes on Vulkan with shadows enabled. While this doesn't fix shadow rendering, it at least fixes a related crash so it doesn't crash when you switch to Vulkan with shadows enabled.