split shader files across multiple QRC files, partially fix 4.1#2061
split shader files across multiple QRC files, partially fix 4.1#2061ksuprynowicz merged 2 commits intooverte-org:masterfrom
Conversation
e421a5b to
098f026
Compare
There was a problem hiding this comment.
Code diffs look alright to me, the 410 renderer works fine now (tested with MESA_GL_VERSION_OVERRIDE=4.1)
Saw the handful of split RCC calls running while compiling
450, es310, and vk all work fine too
only tested on linux, leaving the QA tag on until someone tests on windows too, though i'm confident it'll work there too
|
hrm actually I'm now seeing something weird in the deferred renderer (on windows) were most shaders are just rendering black (but not all? most unlit shaders seem fine). hadn't noticed because forward renderer works. not sure if it's because of this PR or something that went in recently (vulkan?). @ada-tv does deferred renderer work for you with this on linux? maybe will try a renderdoc capture when I get a chance |
098f026 to
480b7e1
Compare
|
Forward and deferred work properly now on 450, es310, and vk. 410 doesn't work though, likely an unrelated regression related to the new layout macros the Vulkan PR introduced: |
|
I tested it on Windows with OpenVR and OpenXR and everything works well on OpenGL 4.5 |
ah yeah binding is a 4.2 feature. we might just need to remove the changes to the 4.1 header from da01b4c |
|
@ada-tv @HifiExperiments Is this PR safe to merge in your opinion? |
|
yeah - it fixes building on my machine, and I’ve updated the title to reflect that it only partially fixes 4.1. I can look into the remaining issue with 4.1 separately |
|
Thank you! |




fixes #2044 + (partly) #1570