Add public port override option to assingment client#1979
Open
ksuprynowicz wants to merge 2 commits intomasterfrom
Open
Add public port override option to assingment client#1979ksuprynowicz wants to merge 2 commits intomasterfrom
ksuprynowicz wants to merge 2 commits intomasterfrom
Conversation
ksuprynowicz
added
needs CR
Member
Author
|
This is ready for a review and testing. |
JulianGro
reviewed
Jan 14, 2026
|
|
||
| const QCommandLineOption useSamePublicPortsOption(ASSIGNMENT_MONITOR_USE_SAME_PUBLIC_PORTS_OPTION, | ||
| "Normally public ports are discovered using STUN server. " | ||
| "Sometimes this doesn't work and gives wrong port names. " |
Member
There was a problem hiding this comment.
Suggested change
| "Sometimes this doesn't work and gives wrong port names. " | |
| "Sometimes this doesn't work and gives wrong port numbers. " |
Member
|
Fixes #321 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently even if you specify local port for assignment client, public port will be chosen by STUN reply, and will be wrong, making it impossible to connect.
This PR allows specifying public ports so that they can be forwarded on the router.