cleanup python codes #429
cleanup python codes #429
Conversation
• Discovered 10 words that rhyme with "bug fixes". • Say 'minor improvements' again. Say 'minor improvements' again, I dare you. I DOUBLE DARE YOU!
|
overtake seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
buildbox/appdiff.py
Outdated
| for f in files: | ||
| if False and re.match('PlugIns/.*', f): | ||
| # if re.match('PlugIns/.*', f): | ||
| if False: |
There was a problem hiding this comment.
how about d82db8a ?
I try to keep some comments in case of adding them back in the future.
There was a problem hiding this comment.
Well, because this second set isn't used anymore, refactoring of functions that use remove_plugin_files could be even better.
There was a problem hiding this comment.
thanks for confirming, I can delete this part
There was a problem hiding this comment.
Ah, yes, I didn't see that this function essentially does nothing now.
There was a problem hiding this comment.
any thought we could move forward?
|
any thought we could move forward? thanks |
overtake
force-pushed
the
master
branch
3 times, most recently
from
9aa8690 to
579cebb
Compare
7 participants
simplify some python codes