Fix via @bot not shown for inline bot messages in private chats#1387
Open
ettyxne wants to merge 1 commit into
Open
Fix via @bot not shown for inline bot messages in private chats#1387ettyxne wants to merge 1 commit into
ettyxne wants to merge 1 commit into
Conversation
The author/via-bot header block is gated on fillName, which is false for outgoing messages in private chats (no need to show the author name). But the via @bot attribution is rendered inside the same block, so it gets skipped too. Fix: also enter the block when the message has an inline bot attribute, regardless of fillName.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you send a message via an inline bot in a private chat, the "via @botName" attribution doesn't appear.
Root cause: The author/via-bot header block is gated on
fillName, which isfalsefor outgoing messages in private chats (no author name is needed there). The via @bot line is rendered inside the same block, so it gets skipped.Fix: Also enter the block when
message.hasInlineAttributeis true, regardless offillName.