Fix code/monospace formatting lost on copy-paste#1386
Open
ettyxne wants to merge 1 commit into
Open
Conversation
|
|
Copying formatted text strips the code and monospace attributes from the kInApp pasteboard entry, so pasting back into Telegram loses the formatting. The bug: removeAttribute(.code/.monospace) was called on `modified` before building ChatTextInputState from it. Since NSMutableAttributedString is a reference type, mutating it afterward affects the already-captured attributedText, so the encoded kInApp data has no code/monospace runs. Fix: remove those two removeAttribute calls. refreshTextInputAttributes already sets .font to NSFont.code() on every code/monospace run, so RTF export naturally produces monospace output with no extra work. Also move .string out of the `if let rtf` branch and declare all three pasteboard types upfront, as required by the NSPasteboard API contract.
ettyxne
force-pushed
the
fix/monospace-copy-paste
branch
from
4fbbc1a to
0baac64
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copying text that contains inline code or monospace runs and pasting it back into Telegram loses the formatting.
Root cause: Two
removeAttribute(.code/.monospace)calls were made onmodifiedbeforeChatTextInputStatewas built from it. SinceNSMutableAttributedStringis a reference type, mutating it afterward affects the already-capturedattributedText— so the kInApp pasteboard entry ends up with no code/monospace runs.Fix: Remove those two
removeAttributecalls.refreshTextInputAttributesalready appliesNSFont.code()as the.fontattribute on every code/monospace run, so RTF export naturally produces monospace output with no extra work needed.Two smaller fixes included:
.rtf,.kInApp,.string) upfront before setting any values, as required by theNSPasteboardAPI contract