Fix adjacent blockquotes merging into one#1385
Open
ettyxne wants to merge 1 commit into
Open
Conversation
TextInputTextQuoteAttribute.isEqual compared only the collapsed field, so two non-collapsed quotes were considered equal. NSAttributedString merges adjacent runs with equal attribute values, which collapsed all adjacent blockquotes into a single block. Remove the isEqual/hash overrides so NSObject's identity comparison is used — each TextInputTextQuoteAttribute instance is distinct regardless of its collapsed state. Also update quoteRangesEqual to compare .collapsed directly instead of calling isEqual, which after this change would always use identity and return false even for structurally identical ranges.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjacent blockquotes collapse into a single block when typing or pasting.
Root cause:
TextInputTextQuoteAttribute.isEqualcompared only thecollapsedfield, so two non-collapsed quotes were considered equal.NSAttributedStringmerges adjacent attribute runs with equal values — that's what caused the collapse.Fix: Remove the
isEqualoverride.NSObject's identity-based equality ensures each quote block stays distinct regardless of itscollapsedstate.quoteRangesEqualis updated to compare.collapseddirectly instead of callingisEqual, which would otherwise always use identity comparison and return false even for structurally identical ranges, causing unnecessary attribute refreshes.