Windows junction handling for Go 1.23+#176
Open
Nusiq wants to merge 1 commit intootiai10:mainfrom
Open
Conversation
…stent behavior between Go versions before and after version 1.23.
otiai10
reviewed
Dec 2, 2025
|
|
||
| switch { | ||
| case info.Mode()&os.ModeSymlink != 0: | ||
| case info.Mode()&os.ModeSymlink != 0 || info.Mode()&os.ModeIrregular != 0: |
Owner
There was a problem hiding this comment.
How about just adding another case?
Author
There was a problem hiding this comment.
Sure, It's your code. If the junctions are handled the same way as symlinks the result is the same. I'm not sure if they require any special handling so I put it in one case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Go 1.23 changed the junction handling on Windows. Junctions are no longer reported with the
os.ModeSymlinkbit set. Instead, they set theos.ModeIrregular.This PR makes the the copy function correctly copy the junctions again, like it used to do before Go 1.23 instead of returning an error.