Extract Executor base class for rclcpp-free coroutine primitives#39
Merged
Extract Executor base class for rclcpp-free coroutine primitives#39
Conversation
Introduce Executor base class with resume() and post() so that Event, Mutex, and Channel depend only on pure C++ headers. Move their implementations out of co_context.hpp into their own headers. CoContext inherits from Executor — existing API unchanged. Add test_pure_headers that compiles without rclcpp on include path.
otamachan
force-pushed
the
refactor/executor-base-class
branch
from
7515310 to
9516ab5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce Executor base class with resume() and post() so that Event, Mutex, and Channel depend only on pure C++ headers. Move their implementations out of co_context.hpp into their own headers. CoContext inherits from Executor — existing API unchanged.
Add test_pure_headers that compiles without rclcpp on include path.