better handling of dotfiles for ~/.common_env#1
Open
ninjabong wants to merge 2 commits intoosxc:masterfrom
Open
better handling of dotfiles for ~/.common_env#1ninjabong wants to merge 2 commits intoosxc:masterfrom
ninjabong wants to merge 2 commits intoosxc:masterfrom
Conversation
Member
Author
|
Hrmm will need to update since CI failed with a traceback on my regex, however it's output clearly indicates the existence of both a .bash_profile and .zshrc which are not created "out-of-the-box" in ~/. |
Member
Author
|
bump |
Contributor
|
Let's rebuild it on travis ! In case travis throws weird errors, just relaunch it ! |
|
Will this PR also hide the errors for the non-existing files? |
Member
Author
|
The errors can be safely ignored, but we do need to check for the existence of certain files before we go and blindly squash people's dotfiles, see osxc/legacy-common#8 for more reasoning behind why. |
|
Thanks for the info! At first I thought something went wrong. Love this tool! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
made it more like legacy-common so it also handles .profile as last resort, creating one if needed.