chore(lint): add golangci-lint config with depguard rules#713
Open
osvaldoandrade wants to merge 1 commit into
Open
chore(lint): add golangci-lint config with depguard rules#713osvaldoandrade wants to merge 1 commit into
osvaldoandrade wants to merge 1 commit into
Conversation
Introduce .golangci.yml with ~30 linters enabled and depguard rules that will enforce layer boundaries as the refactor progresses: - internal/core: stdlib + pkg/types only; blocks database/sql, net/http, grpc, gin, redis, pebble, raft. - pkg/types, pkg/plugin, pkg/auth: blocks any internal/ import. Complexity thresholds: cyclop 10, gocognit 15, funlen 80 lines. Generated .pb.go files exempt. Test files relaxed. Refs #645 #657
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
.golangci.ymlwith ~30 linters and depguard rules that will enforce layer boundaries as the refactor progresses.Details
internal/core/**: stdlib +pkg/types+pkg/pluginonly; blocksdatabase/sql,net/http, gRPC, Gin, Redis, Pebble, Raft.pkg/{types,plugin,auth}/**: blocks anyinternal/import.*.pb.go,*.pb.gw.go) exempt.gci(with project prefix),gofumpt,goimports.Rules referencing
internal/coreandpkg/types/pkg/pluginactivate as those packages are created in epics #646 and #647.Test plan
golangci-lint runand exits cleanly on current codebase.internal/coreis introduced, an import ofnet/httpfrom there fails the lint job.Closes #657
Part of #645