Skip to content

Conversation

@glymehrvrd
Copy link

Hi, I have done some coding to make it available on st3.
works well on Ubuntu, test function is not tested.

@ostinelli
Copy link
Owner

I see that there are a lot of changes that are related to code style preferences (for example, here), and to the fact that different spacing is used.
Also, there are a lot of different commits.

Please adapt to code styling, provide only real changes, and stash everything into a single commit if you want me to review.

Best,
r.

@ostinelli
Copy link
Owner

Also, there already is work done for ST3 here: #78. Why wasn't this good and you provided an alternative?

@glymehrvrd
Copy link
Author

The code #78 supports windows only, and I found the code #78 still uses SublimErlGlobal. I think using SublimErlGlobal is not a good idea since st3 loads plugins async. So I do lots of changes to make the code more adapt to st3.
I will organize my commits later when I have free time :)

- remove class SublimerlGlobal, extract its methods into outter
  functions.
+ add sublimerl.py, make it the entry of this plugin.
* move original *.py into package sublimerl_lib.
+ add some comments.
* modify completion templete to make the last jumping point exactly right to the rightest braket.
- man function, I use Zeal instead.
+ erlang parser can detect -compile([export_all]) now.
+ add function search, format code into context menu.
* if rebar.config and ebin cannot be found, use editing file's path as
root.
@glymehrvrd
Copy link
Author

@ostinelli , hi, I have tried to make my commits more tidy, see is that acceptable for u. :D

glymehrvrd and others added 7 commits December 6, 2014 23:25
- remove redundant code.
* fix whether context is enabled.
Warning: erl_scan:token_info/2: deprecated (will be removed in OTP 19); use erl_scan:{category,column,line,location,symbol,text}/1 instead
Fix erl_scan:token_info deprecated warning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants