Conversation
ffontaine
force-pushed
the
fix-endpoints
branch
14 times, most recently
from
dd58616 to
bef651b
Compare
Drop unneeded entries from allowed-endpoints in github workflows Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
ffontaine
force-pushed
the
fix-endpoints
branch
from
bef651b to
3ce09ca
Compare
| *.codecov.io:443 | ||
| codecov.io:443 |
There was a problem hiding this comment.
I wouldn't remove these just yet - as discussed with Terri in #5478, we'll create a new account moving forward, as gathering the code coverage is still useful.
|
I haven't had time to look in detail, so may be missing something obvious - but I'm puzzled why so many are not needed. Aren't at least some of those long/external tests supposed to actually reach out to those providers to fetch data during testing? |
|
Yes, I have the same feeling that's why I didn't merge it yet. I think one of the explanation is that all our tests are using a cached database that is built once a day by |
|
Right, I though of that as well, but then I had an impression that at least some tests are ought to go download things from servers anyway when testing. Anyway, this I guess calls for some deeper dive into our tests to see what exactly is going one there. Didn't have time this week, so maybe the next one. |
2 participants
Drop unneeded entries from allowed-endpoints in github workflows