Skip to content

deps: update dependency com.icegreen:greenmail to v2#6616

Merged
sschuberth merged 2 commits intomainfrom
renovate/major-greenmail
Mar 9, 2023
Merged

deps: update dependency com.icegreen:greenmail to v2#6616
sschuberth merged 2 commits intomainfrom
renovate/major-greenmail

Conversation

@renovate
Copy link
Copy Markdown
Contributor

@renovate renovate Bot commented Mar 5, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
com.icegreen:greenmail (source) 1.6.14 -> 2.0.0 age adoption passing confidence

Release Notes

greenmail-mail-test/greenmail

v2.0.0

Compare Source


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate Bot requested a review from a team as a code owner March 5, 2023 20:43
@sschuberth

This comment was marked as outdated.

@sschuberth sschuberth force-pushed the renovate/major-greenmail branch from b4c798d to 23dd75d Compare March 6, 2023 14:13
@renovate
Copy link
Copy Markdown
Contributor Author

renovate Bot commented Mar 6, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@sschuberth
Copy link
Copy Markdown
Member

For simplicity, this also slightly changes the behavior: In case of a plain-text email, the email is now sent as single-part instead of multi-part.

Is that bit a problem for your use-cases @MarcelBochtler and / or @nnobelis?

@sschuberth sschuberth force-pushed the renovate/major-greenmail branch from 23dd75d to 4af9ebb Compare March 6, 2023 14:15
Comment thread notifier/src/main/kotlin/modules/MailNotifier.kt Fixed
Comment thread notifier/src/main/kotlin/modules/MailNotifier.kt Fixed
Comment thread notifier/src/main/kotlin/modules/MailNotifier.kt Fixed
@sschuberth sschuberth force-pushed the renovate/major-greenmail branch from 4af9ebb to 3646d73 Compare March 6, 2023 14:23
The use of `jakarta.mail` and its predecessor `javax.mail` cannot be
mixed. As GreenMail 2.0 migrated to `jakarta.mail` [1] but `commons-email`
does not support `jakarta.mail` yet [2], simply remove `commons-email`
in favor of using `jakarta.mail` directly to resolve the conflict.

For simplicity, this also slightly changes the behavior: In case of a
plain-text email, the email is now sent as single-part instead of
multi-part.

[1]: https://github.com/greenmail-mail-test/greenmail/releases/tag/release-2.0.0
[2]: apache/commons-email#133

Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
@sschuberth sschuberth force-pushed the renovate/major-greenmail branch from 3646d73 to 3a7f741 Compare March 6, 2023 17:17
@MarcelBochtler
Copy link
Copy Markdown
Member

For simplicity, this also slightly changes the behavior: In case of a plain-text email, the email is now sent as single-part instead of multi-part.

Is that bit a problem for your use-cases @MarcelBochtler and / or @nnobelis?

No, our use cases still work as expected.

@sschuberth
Copy link
Copy Markdown
Member

No, our use cases still work as expected.

Thanks for checking!

@sschuberth sschuberth merged commit 7731877 into main Mar 9, 2023
@sschuberth sschuberth deleted the renovate/major-greenmail branch March 9, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants