Scaling up gobgp, handleFSMMessage re-entrant#3303
Draft
nplanelcisco wants to merge 9 commits intoosrg:masterfrom
Draft
Scaling up gobgp, handleFSMMessage re-entrant#3303nplanelcisco wants to merge 9 commits intoosrg:masterfrom
nplanelcisco wants to merge 9 commits intoosrg:masterfrom
Conversation
Member
|
I think that adding RWMutex to destination consumes too much memory. If we enable concurrent access to a table, sharding would be an option. |
2030812 to
1ffc9bf
Compare
Contributor
Author
Thank you, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will enable
handleFSMMessagefunction to be re-entrant, this will allow peers to run in parallelNotes:
o adj tables are accessed under s.shared.Lock()
o I ran some benchmark and fuzzing adding/delete peers and path dynamically under
-racePlan:
I let this PR as draft as it missing
o a concurrent
manager.Table.Update()race unit testso some benchmark results