Skip to content

Fix inaccessible NRPN values #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
blower5 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix inaccessible NRPN values #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions MidiDriverBase.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -550,8 +550,15 @@ void MidiDriverBase::parseDataEntryLSB(int ch, int value)
//-----------------------------------------------------------------------------
void MidiDriverBase::parseDataEntryMSB(int ch, int value)
{
mChStat[ch].dataEntryValue &= 0x00ff;
mChStat[ch].dataEntryValue |= (value & 0x7f) << 8;
mChStat[ch].dataEntryValue &= 0x007f;
//inverts lower bits when negative
if (value > 0x3f)
{
mChStat[ch].dataEntryValue = 0x7f - mChStat[ch].dataEntryValue;
}
//set highest bit only
mChStat[ch].dataEntryValue |= (value & 0x40) << 1;
handleDataEntryValueChange(ch, mChStat[ch].isSettingNRPN, mChStat[ch].isSettingNRPN ? mChStat[ch].nrpn : mChStat[ch].rpn, mChStat[ch].dataEntryValue);
}

//-----------------------------------------------------------------------------
Expand Down
Binary file modified dist/win/x64/C700.dll
View file
Open in desktop
Binary file not shown.
Binary file modified dist/win/x86/C700.dll
View file
Open in desktop
Binary file not shown.