Report progress when reading PBF files #398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Greetings libosmium team 👋 Does this change make sense to you? I believe the CI failure is unrelated to my changes, that looks like a pre-build script failure. Could you please take a look? |
Member
|
Sorry, I'll take a look when I'll have the time. Pushing is not going to make this any faster. |
Member
|
This regression was introduced in 4ce5fb6. |
Member
|
Thanks. Sorry this took me so long. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like the
m_offset_ptrvalue is never updated when usingPBFParserwithDummyDecompressor.