-
Notifications
You must be signed in to change notification settings - Fork 110
UI fixes after migration to ios 26 #5232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
59 commits
Select commit
Hold shift + click to select a range
c41833a
[WIP] pencil icon for favorite list edit button
Vladyslav-lys 6e85808
[WIP] hide search in edit for my favorites
Vladyslav-lys ce0aceb
Merge branch 'master' into ui_fixes_after_migration_to_ios_26
Vladyslav-lys 304634e
Merge branch 'master' into ui_fixes_after_migration_to_ios_26
Vladyslav-lys 8551841
[WIP] search disappears if go to favorites fixed, tab bar behind sear…
Vladyslav-lys 68a38b1
[WIP] learn more text fixed, reset icon color and button size fixed
Vladyslav-lys 1148f8f
Merge branch 'master' into ui_fixes_after_migration_to_ios_26
Vladyslav-lys 528d528
[WIP] updated choose plan navbar
Vladyslav-lys 4d740ee
[WIP] title covered by navbar fixed
Vladyslav-lys 6cd4ada
[WIP] maps and resources update button updated
Vladyslav-lys 4174525
[WIP] maps and resources dialog below search fixed
Vladyslav-lys 38e43eb
[WIP] my favorites menu icon size updated
Vladyslav-lys 4879718
[WIP] tracks action color in navbar fixed
Vladyslav-lys b25fe07
[WIP] updated track context menu image size
Vladyslav-lys 31f4107
[WIP] updated track bar button color
Vladyslav-lys 200285b
[WIP] tab bar behind search after import folder fixed
Vladyslav-lys 5fafa0d
[WIP] background below search in folders removed
Vladyslav-lys 1111983
[WIP] updated right button size in navbar
Vladyslav-lys 984d740
[WIP] updated navbar for quick actions screen
Vladyslav-lys 48201d2
[WIP] speedometer, distance by tap, weather layer settings switch ani…
Vladyslav-lys c2a364d
[WIP] speedometer screen title disappears fixed
Vladyslav-lys 76ff81d
[WIP] refactored
Vladyslav-lys 445b1fd
[WIP] icon on configure profile removed
Vladyslav-lys b5944ee
[WIP] crippled switch animation on configure profile fixed
Vladyslav-lys c0f19b9
[WIP] navbar separator removed
Vladyslav-lys 20b51f3
[WIP] separator height in profile appearance fixed
Vladyslav-lys 4827c02
[WIP] resting and navigation icons background updated
Vladyslav-lys f7718bd
[WIP] right navbar button if no history hidden, switch animation fixed
Vladyslav-lys f19469c
[WIP] pro button corner style updated
Vladyslav-lys e95af6b
[WIP] refactored
Vladyslav-lys b2c5e3a
[WIP] crippled switch animation for configure map fixed
Vladyslav-lys c527d07
[WIP] missing navbar title in osmand cloud fixed
Vladyslav-lys e7b963f
[WIP] search on tracks fixed
Vladyslav-lys 40c69a9
[WIP] base navbar view controller refactored
Vladyslav-lys df352c0
[WIP] tracks refactored
Vladyslav-lys c1e6e7d
[WIP] choose plan view controller refactored
Vladyslav-lys 3d03faa
[WIP] purchases refactored
Vladyslav-lys 9a944c1
Update OABaseNavbarViewController.m
Vladyslav-lys 278ebcb
refactored
Vladyslav-lys a434122
tabs titles cover images on tabbar fixed
Vladyslav-lys 48e083e
updated back button, fixed segmented control for create poi
Vladyslav-lys fd3f7ca
conflicts resolved
Vladyslav-lys 8b09694
Update Contents.json
Vladyslav-lys c29a0f3
Update OABaseNavbarViewController.m
Vladyslav-lys bc05c14
Update OABaseNavbarViewController.m
Vladyslav-lys 52aa1f1
Update OAChoosePlanViewController.mm
Vladyslav-lys 366651f
updated base navbar view controller
Vladyslav-lys 89351d5
Update OACardButtonCell.mm
Vladyslav-lys 59d1ec0
image string name to constants changed
Vladyslav-lys 68f6cd2
reload data method using updated
Vladyslav-lys e9fa07f
Update TracksViewController.swift
Vladyslav-lys 5e93a18
using title for ios 26 updated
Vladyslav-lys e78853c
conflict resolved
Vladyslav-lys 65db2ca
scaled menu image size
Vladyslav-lys d4ec84d
ios 26 checking for cached tab bar height
Vladyslav-lys d7d68f8
Update OAFavoriteListViewController.mm
Vladyslav-lys 9ab75ba
updated menu icons
Vladyslav-lys de6d40b
refactored
Vladyslav-lys 0062ed0
isIOS26 method removed
Vladyslav-lys File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
Binary file not shown.
Binary file not shown.
26 changes: 26 additions & 0 deletions
26
Resources/Images.xcassets/Icons/ic_navbar_help.imageset/Contents.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| { | ||
| "images" : [ | ||
| { | ||
| "idiom" : "universal", | ||
| "scale" : "1x" | ||
| }, | ||
| { | ||
| "filename" : "ic_navbar_help@2x.png", | ||
| "idiom" : "universal", | ||
| "scale" : "2x" | ||
| }, | ||
| { | ||
| "filename" : "ic_navbar_help@3x.png", | ||
| "idiom" : "universal", | ||
| "scale" : "3x" | ||
| } | ||
| ], | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| }, | ||
| "properties" : { | ||
| "preserves-vector-representation" : true, | ||
| "template-rendering-intent" : "template" | ||
| } | ||
| } |
File renamed without changes
File renamed without changes
26 changes: 26 additions & 0 deletions
26
Resources/Images.xcassets/Icons/ic_navbar_overflow_menu_stroke.imageset/Contents.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| { | ||
| "images" : [ | ||
| { | ||
| "idiom" : "universal", | ||
| "scale" : "1x" | ||
| }, | ||
| { | ||
| "filename" : "ic_navbar_overflow_menu_stroke@2x.png", | ||
| "idiom" : "universal", | ||
| "scale" : "2x" | ||
| }, | ||
| { | ||
| "filename" : "ic_navbar_overflow_menu_stroke@3x.png", | ||
| "idiom" : "universal", | ||
| "scale" : "3x" | ||
| } | ||
| ], | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| }, | ||
| "properties" : { | ||
| "preserves-vector-representation" : true, | ||
| "template-rendering-intent" : "template" | ||
| } | ||
| } |
File renamed without changes
File renamed without changes
25 changes: 25 additions & 0 deletions
25
Resources/Images.xcassets/Icons/icon_direction.imageset/Contents.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| { | ||
| "images" : [ | ||
| { | ||
| "idiom" : "universal", | ||
| "scale" : "1x" | ||
| }, | ||
| { | ||
| "filename" : "icon_direction@2x.png", | ||
| "idiom" : "universal", | ||
| "scale" : "2x" | ||
| }, | ||
| { | ||
| "filename" : "icon_direction@3x.png", | ||
| "idiom" : "universal", | ||
| "scale" : "3x" | ||
| } | ||
| ], | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| }, | ||
| "properties" : { | ||
| "preserves-vector-representation" : true | ||
| } | ||
| } |
Binary file added
BIN
+552 Bytes
Resources/Images.xcassets/Icons/icon_direction.imageset/icon_direction@2x.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+1000 Bytes
Resources/Images.xcassets/Icons/icon_direction.imageset/icon_direction@3x.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
25 changes: 25 additions & 0 deletions
25
Resources/Images.xcassets/Icons/icon_direction_active.imageset/Contents.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| { | ||
| "images" : [ | ||
| { | ||
| "idiom" : "universal", | ||
| "scale" : "1x" | ||
| }, | ||
| { | ||
| "filename" : "icon_direction_active@2x.png", | ||
| "idiom" : "universal", | ||
| "scale" : "2x" | ||
| }, | ||
| { | ||
| "filename" : "icon_direction_active@3x.png", | ||
| "idiom" : "universal", | ||
| "scale" : "3x" | ||
| } | ||
| ], | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| }, | ||
| "properties" : { | ||
| "preserves-vector-representation" : true | ||
| } | ||
| } |
Binary file added
BIN
+557 Bytes
...ages.xcassets/Icons/icon_direction_active.imageset/icon_direction_active@2x.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+1020 Bytes
...ages.xcassets/Icons/icon_direction_active.imageset/icon_direction_active@3x.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -35,7 +35,7 @@ - (void) awakeFromNib | |
| - (void) setupViews | ||
| { | ||
| self.separatorInset = UIEdgeInsetsZero; | ||
| self.separatorHeight.constant = 1.0 / [UIScreen mainScreen].scale; | ||
| self.separatorHeight.constant = 1.0; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. up |
||
| self.topTitleOffset.constant = 20; | ||
| self.bottomTitleOffset.constant = 8; | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now the line is always 1 by constant, regardless of screen density.
On Retina screens, it will appear thicker than before, because 1 point = 2–3 pixels.
Visually, the line may look bolder than on the original device.