Skip to content

Support for jetty12 #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jad-el-khoury wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Support for jetty12 #507

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6119725
Support for jetty12
Jad-el-khoury Feb 17, 2026
6fb39e3
Dockerfile for jetty to use ee10
Jad-el-khoury Feb 17, 2026
63e0206
Configure compiler plugin for common-lib project.
Jad-el-khoury Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion model/toolchain.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
<resourceTypes href="../org.eclipse.lyo.tools.domainmodels/oslcDomainSpecifications.xml#_pnz6IJUdEeq-KoPaR9_Cfg"/>
<resourceTypes href="../org.eclipse.lyo.tools.domainmodels/oslcDomainSpecifications.xml#_pn2WYZUdEeq-KoPaR9_Cfg"/>
</webServices>
<trsService xsi:type="oslc4j_ai:InmemPagedTrsService" basePageLimit="50" changeLogPageLimit="50"/>
<trsService xsi:type="oslc4j_ai:InmemPagedTrsService" basePageLimit="5" changeLogPageLimit="5"/>
Copy link

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The basePageLimit and changeLogPageLimit have been significantly reduced from 50 to 5. This appears to be an unintentional change that is not related to the Jetty 12 migration. This change could impact performance and functionality by reducing pagination limits to only 5 items per page. Unless this is intentional for testing purposes, it should be reverted to 50.

Suggested change
<trsService xsi:type="oslc4j_ai:InmemPagedTrsService" basePageLimit="5" changeLogPageLimit="5"/>
<trsService xsi:type="oslc4j_ai:InmemPagedTrsService" basePageLimit="50" changeLogPageLimit="50"/>

Copilot uses AI. Check for mistakes.
<specification/>
<requiredAdaptors xsi:type="oslc4j_ai:GenericRequiredAdaptor" serviceProviderCatalogURI="http://your.host.com/adaptor/services/catalog/singleton" name="GenericRequiredAdaptor"/>
<configuration xsi:type="oslc4j_ai:MavenServerConfiguration" rootServerBaseUrl="http://localhost:8800/" applicationContextPath="/" servletUrlPattern="/services/*" jettyPort="8800">
Expand Down
18 changes: 18 additions & 0 deletions src/lib-common/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,4 +96,22 @@
<scope>test</scope>
</dependency>
</dependencies>
<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-enforcer-plugin</artifactId>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<version>3.14.1</version>
<configuration>
<compilerArgument>
-Xlint:fallthrough,unchecked,removal,deprecation,dep-ann,varargs,overloads,serial,try,finally
</compilerArgument>
</configuration>
</plugin>
</plugins>
</build>
</project>
2 changes: 1 addition & 1 deletion src/server-am/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,6 @@ LABEL org.opencontainers.image.licenses="EPL-2.0"

COPY --from=build /src/server-am/target/*.war /var/lib/jetty/webapps/ROOT.war

RUN java -jar "$JETTY_HOME/start.jar" --add-modules=ee9-deploy,ee9-jsp,ee9-jstl
RUN java -jar "$JETTY_HOME/start.jar" --add-modules=ee10-deploy,ee10-jsp,ee10-jstl

EXPOSE 8080
17 changes: 9 additions & 8 deletions src/server-am/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,14 +286,15 @@
<build>
<finalName>${application.filename}</finalName>
<plugins>
<!-- Start of user code plugins
-->
<!-- Start of user code plugins_start
-->
<!-- TODO: Add additional plugins here to avoid them be overridden upon future re-generation -->
<!-- End of user code
-->
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-enforcer-plugin</artifactId>
</plugin>
<!-- End of user code
-->
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
Expand All @@ -305,9 +306,9 @@
</configuration>
</plugin>
<plugin>
<groupId>org.eclipse.jetty</groupId>
<artifactId>jetty-maven-plugin</artifactId>
<version>11.0.20</version>
<groupId>org.eclipse.jetty.ee10</groupId>
<artifactId>jetty-ee10-maven-plugin</artifactId>
<version>12.0.16</version>
<configuration>
<webApp>
<contextPath>${application.contextpath}</contextPath>
Expand Down Expand Up @@ -396,7 +397,7 @@
</configuration>
</plugin>

<!-- Start of user code plugins
<!-- Start of user code plugins_final
-->
<!-- End of user code
-->
Expand Down
Loading
Loading