Relax rules for green tests and introduce markdown format#31
Draft
marusak wants to merge 3 commits intoosbuild:mainfrom
Draft
Relax rules for green tests and introduce markdown format#31marusak wants to merge 3 commits intoosbuild:mainfrom
marusak wants to merge 3 commits intoosbuild:mainfrom
Conversation
marusak
force-pushed
the
fixes-correct_repo
branch
from
10c61e8 to
bd2e16d
Compare
ochosi
reviewed
Jan 26, 2024
Collaborator
ochosi
left a comment
ochosi
left a comment
There was a problem hiding this comment.
@marusak I'd prefer it if the two changes went into separate PRs. The markdown support looks super straightforward (apart from parts of the code feeling like duplication), so I'd love to get that in asap to enable your team to use this!
| # 4. Needs conflict resolution or rebasing | ||
| elif (not pull_request['changes_requested'] and | ||
| (pull_request['mergeable_state'] in {'dirty', 'behind'})): | ||
| elif (pull_request['mergeable_state'] in {'dirty', 'behind'}): |
Collaborator
There was a problem hiding this comment.
I understand and agree with the motivation for this change, but won't this lead to PRs showing up twice on the list?
ochosi
requested changes
Jan 30, 2024
Collaborator
ochosi
left a comment
ochosi
left a comment
There was a problem hiding this comment.
Let's split this into two PRs, one for markdown and one for relaxing the rules
Contributor
Author
|
Sent #34 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.