cmd/image-builder: mock simple integration tests (HMS-10857)#2473
Open
supakeen wants to merge 1 commit into
Open
cmd/image-builder: mock simple integration tests (HMS-10857)#2473supakeen wants to merge 1 commit into
supakeen wants to merge 1 commit into
Conversation
achilleas-k
previously approved these changes
Jun 29, 2026
achilleas-k
left a comment
achilleas-k
left a comment
Member
There was a problem hiding this comment.
Very nice.
I'm sure we can get more improvements to the loading times once we're done with the merge and can focus on the loader.
Member
Author
|
It seems that with some (new?) tests we now have downstream failures in RPM builds or is this caused by this PR. I'll take a look in the morning. |
supakeen
force-pushed
the
mock-unit-tests
branch
3 times, most recently
from
ba5bac9 to
9693fa1
Compare
Mock the integration tests that are easy and straightforward to mock. This reduces the test time significantly as we're not performing real dependency solving anymore in most of the tests. The resolvers are duplicated here but could later be shared. Signed-off-by: Simon de Vlieger <cmdr@supakeen.com>
supakeen
force-pushed
the
mock-unit-tests
branch
2 times, most recently
from
c6bf538 to
cc3c92e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mock the integration tests that are easy and straightforward to mock. This reduces the test time significantly as we're not performing real dependency solving anymore in most of the tests.
Note this doesn't really make things faster that much. The test suite still takes long as almost every test calls
main.Run()which loads distribution definitions which takes 2-3 seconds for every test.We also can't make the tests parallel without rewriting the entire mocking strategy since we're mocking globals 🙁