fix: restore OTEL trace propagation in remote and remote_json authorizers#1259
Closed
rdark wants to merge 2 commits intoory:masterfrom
Closed
fix: restore OTEL trace propagation in remote and remote_json authorizers#1259rdark wants to merge 2 commits intoory:masterfrom
rdark wants to merge 2 commits intoory:masterfrom
Conversation
…zers The httpx.ResilientClientWithTracer option was removed from ory/x during the monorepo migration, but the remote and remote_json authorizers were not updated to compensate. Their HTTP clients now use a plain transport with no trace context propagation, breaking distributed tracing to downstream services. Restore propagation by wrapping the client transport with otelhttp.NewTransport after construction. This uses the global OTEL TracerProvider (already registered by otelx.SetupOTLP via otel.SetTracerProvider), consistent with how authenticator_cookie_session.go handles the same requirement. The fix applies to both the initial client in the constructor and the retry client rebuilt in Config() when timeout/max-wait settings are present. NOTE: Two stale entries in go.mod pruned by go mod tidy
The docs-cli job was missing the ory/ci/checkout@master step before actions/setup-go, causing "go version file at: go.mod does not exist" failures because the repository was never checked out into the workspace.
aeneasr
approved these changes
Feb 27, 2026
Author
|
@aeneasr thanks for approval - this PR is blocked by a CI issue that should be fixed in ory/meta#245, which is itself blocked by another CI issue (looks like missing secrets config) |
Member
|
Thank you! We still have some work to do to get the monorepo set up working 100% for the OSS pipeline, sorry about that. Also @hperl not sure how that commit was dropped, did we forget to import some git hash? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The httpx.ResilientClientWithTracer option was removed from ory/x during the monorepo migration, but the remote and remote_json authorizers were not updated to compensate. Their HTTP clients now use a plain transport with no trace context propagation, breaking distributed tracing to downstream services.
Restore propagation by wrapping the client transport with otelhttp.NewTransport after construction. This uses the global OTEL TracerProvider (already registered by otelx.SetupOTLP via otel.SetTracerProvider), consistent with how authenticator_cookie_session.go handles the same requirement.
The fix applies to both the initial client in the constructor and the retry client rebuilt in Config() when timeout/max-wait settings are present.
NOTE: Two stale entries in go.mod pruned by go mod tidy
Related issue(s)
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
security@ory.com) from the maintainers to push
the changes.
works.
Further Comments