fix: update regex engine to support possessive match and lookbehind syntaxes#1147
Open
cmmoran wants to merge 4 commits intoory:masterfrom
Open
fix: update regex engine to support possessive match and lookbehind syntaxes#1147cmmoran wants to merge 4 commits intoory:masterfrom
cmmoran wants to merge 4 commits intoory:masterfrom
Conversation
…ters if the regexp contains possessive match or lookbehind syntax.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1147 +/- ##
==========================================
- Coverage 77.90% 77.88% -0.03%
==========================================
Files 80 80
Lines 3929 4047 +118
==========================================
+ Hits 3061 3152 +91
- Misses 595 616 +21
- Partials 273 279 +6 ☔ View full report in Codecov by Sentry. |
Member
|
Thank you for the changes, however the reason lookbehind is not working is because we're using the golang std library, which does not support these features. |
Member
|
I'm actually wrong, looksl ike this is working, which is very nice! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the regexp to conditionally (naively?) change the current start,end delimiters for the regexp from the hard-coded '<','>' to '{','}' when the compiler encounters a pattern that has syntax that includes '(?<' or '(?>' organically.
BREAKING CHANGES: None
Related issue(s)
Relates:
#441
Fixes:
#1089
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
Further Comments