This repository was archived by the owner on May 12, 2025. It is now read-only.
allow correct redirects for apps using next basePath#47
Open
RokoTechnology wants to merge 2 commits intoory:mainfrom
Open
allow correct redirects for apps using next basePath#47RokoTechnology wants to merge 2 commits intoory:mainfrom
RokoTechnology wants to merge 2 commits intoory:mainfrom
Conversation
|
|
aeneasr
reviewed
Jan 10, 2023
Member
aeneasr
left a comment
aeneasr
left a comment
There was a problem hiding this comment.
Awesome, thank you for your contribution! This looks pretty good and I have some ideas how to improve it further :)
Comment on lines
+120
to
+123
| /* | ||
| * You can pass your next.config.js basePath here if your app lives on a subpath of the domain. | ||
| */ | ||
| appBasePath?: string |
Member
There was a problem hiding this comment.
Would it be possible to instead load this from next itself directly? That way we can avoid another config parameter and it would just work with magic? :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see issue #45