Feat/add e2e to external example pack#153
Merged
Merged
Conversation
Add comprehensive suite-level results display for e2e test imports: - Add ImportResult struct capturing path, Result, and error for each import - Change runImports return type from []error to []ImportResult - Implement printImportSummary with formatted table output - Show pass/fail status, test counts, duration, and failure reasons - Display overall suite summary (X of Y imports passed, total duration) Example output: ─── Suite Results: multi-tenancy-suite ─── ✓ multi-tenancy-basic-e2e 8 / 8 53s ✗ cross-access-control-e2e 0 / 4 12s → CrashLoopBackOff ✓ shared-platform-e2e 4 / 4 3m17s 2 of 3 imports passed (4m22s) Also updates cross-access-control example: - Fix e2e.yaml configuration for proper import testing - Update README with suite results documentation - Fix katalog.yaml for cross-access-control scenario This provides clear visibility into multi-test suite execution and makes debugging failed imports much easier.
Adds devServer bool to New() and Runner. When set, deploys ghcr.io/orkspace/orkestra-dev-server:latest as a Deployment+Service into orkestra-system before Orkestra installs, waits for it with DeploymentHealthChecker, and tears it down automatically.
Each cr-e2e.yaml uses orkestra-dev-server.orkestra-system.svc:9999 instead of localhost:9999 — works from inside the cluster without host networking. Root e2e.yaml imports all 10 sub-tests.
All 10 external examples now have runnable e2e. Tests lifted from README verification steps — asserts both happy path and rejection cases (07-vault, 08-opa each verify blocked paths with status checks).
Each README now has a '## E2E' section showing the run command (ork e2e --dev-server), explaining cr-e2e.yaml, and showing the key expectations inline — following the enrich/03-rollout-observer README pattern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ork e2e --dev-serverflag that deploysghcr.io/orkspace/orkestra-dev-server:latestas a Kubernetes Deployment+Service intoorkestra-systembefore Orkestra installs, making the mock server available atorkestra-dev-server.orkestra-system.svc:9999from inside the clustercmd/devserver/main.gostandalone entry point,make docker-devserver/make release-devservertargets, and abuild-devserverCI job inbuild-push-images.yml— built and pushed alongside runtime/gateway/cccr-e2e.yamlfor all 10 external examples using the in-cluster DNS address instead oflocalhost:9999e2e.yamlfor all 10 external examples with meaningful assertions lifted from README verification steps — happy path + rejection case where applicable (07-vault, 08-opa)examples/use-cases/external/e2e.yamlsuite that imports all 10## E2Esection to all 10 external example READMEsTest plan
ork validate -f e2e.yamlpasses on root external suite (10 imports valid)ork e2e --use-current --dev-serverpasses on all 10 examples individuallymake orkandgo build ./cmd/devserver/...compile clean