Skip to content

node: update sequelize and knex docs for TraceProvider#72

Merged
odeke-em merged 5 commits into
orijtech:masterfrom
aabmass:update-docs
Nov 12, 2020
Merged

node: update sequelize and knex docs for TraceProvider#72
odeke-em merged 5 commits into
orijtech:masterfrom
aabmass:update-docs

Conversation

@aabmass

@aabmass aabmass commented Nov 11, 2020

Copy link
Copy Markdown
Contributor

These have a bit more than #70 #69 which can be closed after this PR.

  • update sequelize documentation with TraceProvider and samples
  • update knex documentation with TraceProvider and samples

@aabmass aabmass changed the title update docs node: update sequelize and knex docs for TraceProvider Nov 11, 2020
@aabmass aabmass marked this pull request as ready for review November 11, 2020 19:46

@odeke-em odeke-em left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @aabmass for this change, LGTM except for some minor changes!

Comment thread content/node/knex/_index.md Outdated
Comment thread content/node/sequelize/_index.md Outdated
@aabmass

aabmass commented Nov 11, 2020

Copy link
Copy Markdown
Contributor Author

Checkmarks added

@aabmass

aabmass commented Nov 11, 2020

Copy link
Copy Markdown
Contributor Author

@odeke-em is there a script to update the table of contents?

@odeke-em

odeke-em commented Nov 11, 2020 via email

Copy link
Copy Markdown
Member

@aabmass

aabmass commented Nov 11, 2020

Copy link
Copy Markdown
Contributor Author

Updated TOC

@odeke-em odeke-em merged commit 9c142ac into orijtech:master Nov 12, 2020
@odeke-em

Copy link
Copy Markdown
Member

I’ll just need to Hugo generate and then push to the gh-pages branch of google/sqlcommenter and it’ll all be live.

@aabmass aabmass deleted the update-docs branch November 12, 2020 16:15
odeke-em added a commit to google/sqlcommenter that referenced this pull request Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants