Skip to content

Add wrap - A small bubblewrap like program#18

Merged
stikonas merged 8 commits intooriansj:masterfrom
MaxHearnden:wrap
Dec 12, 2023
Merged

Add wrap - A small bubblewrap like program#18
stikonas merged 8 commits intooriansj:masterfrom
MaxHearnden:wrap

Conversation

@MaxHearnden
Copy link
Copy Markdown
Contributor

@MaxHearnden
Copy link
Copy Markdown
Contributor Author

This program does run into https://gitlab.com/qemu-project/qemu/-/issues/871 when using qemu user mode emulation

Copy link
Copy Markdown
Collaborator

@stikonas stikonas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps you can format them in the same style as other mescc-tools-extra programs?

@stikonas
Copy link
Copy Markdown
Collaborator

stikonas commented Dec 9, 2023

This program does run into https://gitlab.com/qemu-project/qemu/-/issues/871 when using qemu user mode emulation

Hmm, I guess that's mostly fine and it's qemu bug anyway. This would only affect us if we want to use this wrap when trying to build another arch, e.g. riscv64. That's mostly a development scenario and we could still use bubblewrap in that case.

Comment thread wrap.c Outdated
Copy link
Copy Markdown
Collaborator

@stikonas stikonas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good here but you need to rebase on top of latest commit. There are some non-trivial makefile fixes that will also affect your changes.

@stikonas stikonas merged commit f8befe3 into oriansj:master Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants