Maintenance/move to internal package#164
Merged
Merged
Conversation
l00ptr
changed the title
Owner
|
Hi, it's nice to reorganize code like this. Just one comment on pg_back.conf, I think it should be left a the root of the project for better visibility. If that's not possible with embed, maybe just add a symlink so that it can be found easily from the root. Regards |
We also standardize logger dependencies. Centralize responsibilities across the code by reorganizing logic into domain-oriented internal packages and making dependencies explicit in function signatures. With this commit, we also: - Move storage-related logic (upload, purge, locking) into internal/storage; - Move PostgreSQL helpers (connection, SQL execution) into internal/postgresql; - Move hashing and checksum utilities into internal/crypto and improve them; - Move command hooks (pre/post execution) into the command package; - Move shared helpers (path formatting, naming, relPath, etc.) into a helpers package; - Move logger and configuration handling into internal packages; - Refactor pg_dump handling and move command-related logic into internal; Additionally, update function signatures to explicitly pass dependencies (e.g. logger instances) instead of relying on implicit or package-level state. For example: ``` lockPath(path string) → LockPath(logger *logger.LevelLog, path string) ``` This change is intentionally broad and mostly mechanical. While somewhat naive, it establishes a consistent pattern for dependency injection, improves observability, and removes hidden coupling across packages. This is a first step before deeper refactoring.
l00ptr
force-pushed
the
maintenance/move-to-internal-package
branch
from
109404a to
fd98f12
Compare
l00ptr
changed the title
Collaborator
Author
|
@orgrim Could you please review that merge request? If you prefer i can split it into smaller commits. |
orgrim
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.