Update stop-using-put-for-updates.mdx#462
Open
ArchitectedDev wants to merge 2 commits intoordercloud-api:developmentfrom
Open
Update stop-using-put-for-updates.mdx#462ArchitectedDev wants to merge 2 commits intoordercloud-api:developmentfrom
ArchitectedDev wants to merge 2 commits intoordercloud-api:developmentfrom
Conversation
Removing statements that incorrectly refer to PUT requests in the OrderCloud API as being idempotent as this will typically cause the resource IDs to be regenerated by the platform.
Contributor
|
@ajsuth in order to do a PUT you have to have the ID (for the route param) so wouldn't you include that in your request body as well - avoiding the API generating a new ID? |
Contributor
Author
|
@robertsoniv, thanks for the note. The primary goal was to remove the misinformation regarding idempotency for PUT requests. I see now that the removing the incorrect statements does not necessarily resolve the definition for PUT usage, so have updated it to be explicit that the ID is required for both the URI and request body. |
Contributor
Author
|
@robertsoniv, are there any more changes that you would like to see here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing statements that incorrectly refer to PUT requests in the OrderCloud API as being idempotent as this will typically cause the resource IDs to be regenerated by the platform.